This repository was archived by the owner on Oct 21, 2025. It is now read-only.
Show Movement Speed mod on Gamble Sprint#39
Open
CarnegieL wants to merge 5 commits intoPathOfBuildingCommunity:devfrom
Open
Show Movement Speed mod on Gamble Sprint#39CarnegieL wants to merge 5 commits intoPathOfBuildingCommunity:devfrom
CarnegieL wants to merge 5 commits intoPathOfBuildingCommunity:devfrom
Conversation
Added special logic for gamblesprint to make it through to the tooltip. Previous logic filtered any line that had 0% in. Special case added for gamblesprint. Issue #112
Base Block Chance calculation change for shields when Renly's is allocated
This reverts commit a6f81c8.
Forgot to remove experimentation lines! Rectified
Misunderstood the variant system. Updated again
Wires77
suggested changes
Jan 18, 2025
Member
Wires77
left a comment
There was a problem hiding this comment.
These boots still have Lightning resistance on them:
https://pathofexile.com/trade2/search/poe2/Standard/D0Kk8Y4u5
Also unique changes should be made in the src/Export/Uniques files first, and exported to produce the output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #112 .
Description of the problem being solved:
Gamblesprint not showing movement speed modifier. Check for modifiers with '0' value filtered out the mod. Added logic to allow this one through.
Steps taken to verify a working solution:
Before screenshot:
After screenshot: